test: Use common.expectsError in tests#17484
Closed
mithunsasidharan wants to merge 1 commit intonodejs:masterfrom
mithunsasidharan:common_3
Closed
test: Use common.expectsError in tests#17484mithunsasidharan wants to merge 1 commit intonodejs:masterfrom mithunsasidharan:common_3
mithunsasidharan wants to merge 1 commit intonodejs:masterfrom
mithunsasidharan:common_3
Conversation
BridgeAR
approved these changes
Dec 6, 2017
cjihrig
approved these changes
Dec 6, 2017
Contributor
|
Hi @mithunsasidharan — thank you for contributing. Could you use the checklist in your PR to indicate which changes have happened or whether you've run the tests locally? It seems like all your PRs have the checkboxes completely unchecked. In general, it's helpful to at least run |
Contributor
Author
|
@apapirovski : Sorry for missing out on that. I usually run all test for any changes I make |
apapirovski
approved these changes
Dec 6, 2017
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
LGTM. Thanks for updating the checklist 👍
jasnell
approved these changes
Dec 6, 2017
lpinca
approved these changes
Dec 6, 2017
Contributor
maclover7
approved these changes
Dec 7, 2017
maclover7
added
the
author ready
3 tasks
Contributor
|
CI: https://ci.nodejs.org/job/node-test-pull-request/11985/ CI was a little wonky the last time, just running again to be safe. |
Contributor
|
Landed in d8c896c |
apapirovski
pushed a commit
that referenced
this pull request
Dec 8, 2017
PR-URL: #17484 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17484 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17484 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
addaleax
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests to replace
assert.throws(fn, common.expectsError(err)); withcommon.expectsError(fn, err);in following test files :Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test